hevinhsu commented on PR #10539: URL: https://github.com/apache/ozone/pull/10539#issuecomment-5054054026
Thanks @Gargi-jais11 for the update! +1 to @ArafatKhan2198. Bypassing all `x-amz-*` checks feels a bit too broad and risky — per [AWS's presigned URL docs](https://docs.aws.amazon.com/AmazonS3/latest/developerguide/sigv4-query-string-auth.html), any `x-amz-*` header you plan to add to a presigned request must be included in the signature calculation, which doesn't seem to align with skipping the check entirely. Based on that, restricting the exception to `x-amz-acl` makes more sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
