dombizita commented on code in PR #10817:
URL: https://github.com/apache/ozone/pull/10817#discussion_r3636097383
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/FinalizeVersionCommandHandler.java:
##########
@@ -69,10 +69,10 @@ public void handle(SCMCommand<?> command, OzoneContainer
ozoneContainer,
invocationCount.incrementAndGet();
final long startTime = Time.monotonicNow();
DatanodeStateMachine dsm = context.getParent();
- final FinalizeNewLayoutVersionCommandProto finalizeCommand =
+ final FinalizeNewDatanodeVersionCommandProto finalizeCommand =
((FinalizeVersionCommand) command).getProto();
try {
- if (finalizeCommand.getFinalizeNewLayoutVersion()) {
+ if (finalizeCommand.getFinalizeNewDatanodeVersion()) {
Review Comment:
I added the check for DN and SCM software versions mismatch and crashing the
node if needed. Added `TestFinalizeVersionCommandHandler.java` for testing this
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
