errose28 commented on code in PR #10817:
URL: https://github.com/apache/ozone/pull/10817#discussion_r3641329579
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeManager.java:
##########
@@ -375,10 +375,10 @@ void processNodeReport(DatanodeDetails datanodeDetails,
* Process Node LayoutVersion report.
Review Comment:
This javadoc needs to be updated.
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java:
##########
@@ -653,11 +653,11 @@ public void processNodeReport(DatanodeDetails dnUuid,
* Empty implementation for processLayoutVersionReport.
Review Comment:
This javadoc is also stale.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolServerSideTranslatorPB.java:
##########
@@ -71,14 +68,8 @@ public SCMRegisteredResponseProto register(
.getContainerReport();
NodeReportProto dnNodeReport = request.getNodeReport();
PipelineReportsProto pipelineReport = request.getPipelineReports();
- LayoutVersionProto versionInfo = null;
- if (request.hasDataNodeLayoutVersion()) {
- versionInfo = request.getDataNodeLayoutVersion();
- } else {
- // Backward compatibility to make sure old Datanodes can still talk to
- // SCM.
- versionInfo = toVersionProto(INITIAL_VERSION, INITIAL_VERSION);
- }
+ // Datanode version will be fenced during registration.
Review Comment:
```suggestion
// Datanodes which do not report a version will not be allowed to
register.
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java:
##########
Review Comment:
The javadoc on processVersionReport is stale. We can update it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
