ayushtkn commented on code in PR #10910:
URL: https://github.com/apache/ozone/pull/10910#discussion_r3687975008
##########
hadoop-ozone/dist/src/shell/ozone/ozone:
##########
@@ -302,6 +302,7 @@ function ozone_suppress_shell_log
OZONE_LOGLEVEL=OFF
OZONE_ROOT_LOGGER="${OZONE_LOGLEVEL},console"
OZONE_OPTS="${OZONE_OPTS} -Dslf4j.internal.verbosity=ERROR"
+
OZONE_OPTS="-Djava.util.logging.config.file='${OZONE_CONF_DIR}/shell-logging.properties'
${OZONE_OPTS}"
Review Comment:
is quote required here? I was under the impression that the quote will get
resolved as is and shell will receive
`-Djava.util.logging.config.file='.../shell-logging.properties'` and Java will
look for a file with quotes in its name.
Other references in the code don't have a quote
https://github.com/apache/ozone/blob/d97e8d0348692e67b77bb62e5f58c26eb17e2b2a/hadoop-ozone/dist/src/shell/ozone/ozone#L126
https://github.com/apache/ozone/blob/d97e8d0348692e67b77bb62e5f58c26eb17e2b2a/hadoop-ozone/dist/src/shell/ozone/ozone#L159
Can you check once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
