errose28 commented on PR #10918: URL: https://github.com/apache/ozone/pull/10918#issuecomment-5146633321
+1 to the above. Let's at least manually verify that prometheus is showing existing httpfs metrics in the [docker environment](https://github.com/apache/ozone/blob/ab29a55eaea71db9f2912d2fc69c2865cad34af8/hadoop-ozone/dist/src/main/compose/ozone/docker-compose.yaml#L61) (Add [monitoring.yaml](https://github.com/apache/ozone/blob/68af0ac2db3612ee6e82bb9c23289f6311d2b346/hadoop-ozone/dist/src/main/compose/ozone/monitoring.yaml) to your docker compose configuration). If possible it would be good to add a test case to the acceptance tests as well that `curl`s from prometheus and reads httpfs metrics. Also, can you update the target branch to `master` since this change isn't ZDU specific? After this is merged I can do a reverse merge to incorporate it into the ZDU branch so you can continue work on HDDS-15858. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
