arunk-kumar commented on PR #10945:
URL: https://github.com/apache/ozone/pull/10945#issuecomment-5237436709
@chihsuan Thanks for the review!
Issue 1 (unregisterSource): Fixed — removed the
unregisterSource("prometheus") call from stop(). BaseHttpServer.stop() doesn't
call it either; httpServer.stop() handles cleanup. Fix is in the latest commit.
Issue 2 (bearer token vs S3G): You're right that the behavior differs. The
root cause is that HttpFSAuthenticationFilter intercepts all requests
(including /prom) before PrometheusServlet gets a chance to check the bearer
token — unlike S3G which doesn't have that filter. This seems like a
pre-existing inconsistency rather than something introduced by this PR. Happy
to file a follow-up JIRA to track aligning the bearer token behavior across
services, if that would be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
