F64116045 commented on PR #10928: URL: https://github.com/apache/ozone/pull/10928#issuecomment-5172829722
> I think this will be more acute for storageType aware tracking, though before this PR, it was fine because pending count gets removed automatically after rolling window of max 10 mins and without storageType, this conservative approach seems fine as keeping pending count in tracker will rather avoid over-allocating than wait for ageing timeout based removal. But now with storageType aware tracker, the pending count is now precise per type. That means the double-counting problem is more acute — a single confirmed SSD container can block all SSD allocation on that datanode for up to 10 minutes, even though the SSD space is correctly reflected in the heartbeat. Thanks @devmadhuu for the review and the detailed explanation. I updated the PR to record pending allocations after successful container allocation, and to clear them when NodeManager observes the container through addContainer/removeContainer. This keeps the rolling-window cleanup as a fallback, but avoids keeping confirmed allocations pending until the timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
