devmadhuu commented on PR #10928: URL: https://github.com/apache/ozone/pull/10928#issuecomment-5179510008
> Thanks @ashishkumar50 for pointing this out and for the link. > > I realize that master already has the atomic `checkSpaceAndRecordAllocation(...)` flow, but the [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) feature branch does not include that flow yet. This PR is based on [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) because the change depends on the storage policy work there, such as `StorageTier` on pipelines and containers. > > Since this PR depends on the storage policy changes in [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233), I plan to keep the PR targeted there and manually bring in the relevant atomic allocation flow from master. I’d like to avoid merging the full latest master into this PR branch, as that would introduce a very large unrelated diff. > > Please let me know if you have any concerns with this direction, or if you think syncing the atomic allocation flow into [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) should be handled first as a separate prerequisite task. > > Thanks again for the helpful context! @F64116045 . I think I agree with @ashishkumar50 . By rebasing the feature branch with master, your PR will not being lot of diff. Rather your PR changes will still be specific to Storage Policy and atomic allocation flow. So steps below: 1. Rebase [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) with master. It will help any future PRs raised against this feature branch will be less deviated from master and easy for feature branch to merge to master later. 2. After that rebase your PR branch with feature branch, diff should be minimal and focused only for storage policy adaption code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
