echonesis commented on code in PR #10939:
URL: https://github.com/apache/ozone/pull/10939#discussion_r3746168051
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/node/TestDecommissionAndMaintenance.java:
##########
@@ -481,7 +488,7 @@ public void
testSingleNodeWithOpenPipelineCanGotoMaintenance()
// has, then the SCM state should be used and the DN state updated.
waitForDnToReachHealthState(nm, newDn, HEALTHY);
waitForDnToReachOpState(nm, newDn, IN_SERVICE);
- waitForDnToReachPersistedOpState(dn, IN_SERVICE);
+ waitForDnToReachPersistedOpState(newDn, IN_SERVICE);
Review Comment:
This was added while checking the DatanodeDetails lifecycle across DN
restarts.
Since the test already obtains newDn after the restart, using it for the
persisted-state assertion seemed more precise than retaining the pre-restart
reference.
However, you are right that this is in a different test and is not needed to
address the HDDS-16067 failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
