echonesis commented on code in PR #10939:
URL: https://github.com/apache/ozone/pull/10939#discussion_r3746168051
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/node/TestDecommissionAndMaintenance.java:
##########
@@ -481,7 +488,7 @@ public void
testSingleNodeWithOpenPipelineCanGotoMaintenance()
// has, then the SCM state should be used and the DN state updated.
waitForDnToReachHealthState(nm, newDn, HEALTHY);
waitForDnToReachOpState(nm, newDn, IN_SERVICE);
- waitForDnToReachPersistedOpState(dn, IN_SERVICE);
+ waitForDnToReachPersistedOpState(newDn, IN_SERVICE);
Review Comment:
This change was added based on an earlier full-class flaky-test-check:
before the combined fix, 6 of 10 splits failed, while the full class passed
after adding the layout pin and refreshing post-restart DatanodeDetails
references, including this one. At that point, I suspected this assertion could
also be observing a stale pre-restart instance.
However, those changes were not tested independently. Your layout-only run
keeps the original line here and passes the completed full-class iterations, so
I agree that this change is not necessary for HDDS-16067. I’ll revert it to
keep the PR scoped to the isolated root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
