smengcl commented on code in PR #10987: URL: https://github.com/apache/ozone/pull/10987#discussion_r3769733801
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java: ########## Review Comment: Correct, but that cleanup runs only after the synchronous OM requests return. In the deadlock, they never return, so cleanup is never reached. The new `closeSnapshotDbHandles()` calls release only the snapshot DB handles before submission, while the filters retain their `SNAPSHOT_GC_LOCK` locks until the try-with-resources scope closes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
