smengcl commented on PR #10987: URL: https://github.com/apache/ozone/pull/10987#issuecomment-5271992491
> lgtm. > > I can't help but wonder: does DirectoryDeletingService has the same kind of bug? Good point. DDS looks to have the same class of lock lifetime issue. However, DDS uses parallel workers. The task thread retains the current-snapshot DB handle while waiting for parallel workers and later submits the request. Each worker can also retain previous snapshot DB handles while submitting purge requests. Fixing this while preserving DDS parallelism requires different coordination and concurrency coverage. I propose handling DDS in a follow-up Jira and keeping this PR scoped to the KDS path reproduced in the incident. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
