rich7420 commented on code in PR #11066:
URL: https://github.com/apache/ozone/pull/11066#discussion_r3828574874
##########
hadoop-ozone/cli-admin/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestListInfoSubcommand.java:
##########
@@ -459,6 +466,54 @@ private void validateOrderingFromTextOutput(String output,
String orderDirection
}
}
+ @ParameterizedTest
+ @EnumSource(value = StorageTier.class, names = {"EMPTY"}, mode =
EnumSource.Mode.EXCLUDE)
Review Comment:
Why exclude `EMPTY`? `EMPTY.getTierName()` is `"EMPTY"`, so an `EMPTY`-tier
pipeline prints `/[EMPTY]` (not `/[]` like null). If that value is reachable,
is `/[EMPTY]` the intended output or should it render like null? Either way,
worth covering it rather than excluding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
