devmadhuu commented on code in PR #11066:
URL: https://github.com/apache/ozone/pull/11066#discussion_r3868446732
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java:
##########
@@ -243,4 +245,8 @@ private void printDatanodeInfo(BasicDatanodeInfo dn) {
System.out.printf("Percentage Used : %.2f%%%n%n", dn.getPercentUsed());
}
}
+
+ private static String formatSupportedStorageTier(StorageTier tier) {
+ return tier == null ? "[]" : "[" + tier.getTierName() + "]";
Review Comment:
Thanks for the clarification @xichen01 — you're right, I missed the
`Pipeline.toBuilder(HddsProtos.Pipeline)` path where `supportedStorageTier`
defaults to null, so before this feature and upgrade, old pipelines can have
default to null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
