peterxcli commented on code in PR #11143:
URL: https://github.com/apache/ozone/pull/11143#discussion_r3882824401


##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockDataStreamOutput.java:
##########
@@ -187,7 +188,8 @@ void hsyncPropagatesWatchFailure() throws Exception {
 
     // hsync should propagate the watch failure
     assertThrows(IOException.class, stream::hsync, "hsync() must propagate 
IOException from failed watchForCommit");
-    stream.close();
+//    stream.cleanup(false);

Review Comment:
   ```suggestion
   ```
   



##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockDataStreamOutput.java:
##########
@@ -171,10 +171,11 @@ void hsyncPropagatesIOException() throws Exception {
 
     // hsync should propagate the IOException from the failed putBlock
     assertThrows(IOException.class, stream::hsync, "hsync() must propagate 
IOException from failed putBlock");
-    stream.close();
+//    stream.cleanup(false);

Review Comment:
   ```suggestion
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to