rich7420 commented on code in PR #11143:
URL: https://github.com/apache/ozone/pull/11143#discussion_r3886790970
##########
hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/io/TestKeyDataStreamOutput.java:
##########
@@ -227,8 +227,14 @@ void hsyncCallsOmHsyncKey() throws Exception {
}
}
-// @Test - skipped as it fails now
+ @Test
void hsyncWithBlockErrorDoesNotCallOmHsync() throws Exception {
+// MockDatanodePipeline pipeline1 = new MockDatanodePipeline(new BlockID(1,
1));
Review Comment:
nit: commented-out two-pipeline setup (L232-237), please remove.
##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockDataStreamOutput.java:
##########
@@ -171,10 +171,11 @@ void hsyncPropagatesIOException() throws Exception {
// hsync should propagate the IOException from the failed putBlock
assertThrows(IOException.class, stream::hsync, "hsync() must propagate
IOException from failed putBlock");
- stream.close();
+// stream.cleanup(false);
Review Comment:
nit: leftover commented-out code here and at L191, please remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
