priyeshkaratha opened a new pull request, #11188: URL: https://github.com/apache/ozone/pull/11188
## What changes were proposed in this pull request? `DeletedBlockLogStateManagerImpl#removeTransactionsFromDB` marks a batch of transaction IDs as hidden (`deletingTxIDs`), removes each one from the SCM HA transaction buffer, and writes an updated summary — as three separate calls, each independently protected only for its own duration by `SCMHADBTransactionBuffer`'s internal read lock. A concurrent `flush()` (holding the buffer's write lock, e.g. triggered by the periodic flush monitor, a Ratis checkpoint download, or a leader transfer) can land in the gap between these calls. If it lands after a txID has been marked hidden but before it has actually been removed from the buffer, `flush()` calls `onFlush()`, which resets `deletingTxIDs` — while the transaction's row is still durably present in the deleted-blocks table. The row is then re-exposed to `getReadOnlyIterator()` (the deletion scanner) even though its removal is still in progress, which can cause the transaction to be processed again and its summary count to be double-decremented. This PR adds `lock()`/`unlock()` to `SCMHADBTransactionBuffer` (backed by the buffer's existing `ReentrantReadWriteLock` read lock) and has `removeTransactionsFromDB` acquire it across the entire mark-remove- summary sequence. Since `flush()` takes the write lock, it cannot proceed until the whole sequence has released the read lock, so it can only observe the sequence fully completed or not yet started — never midway through. ## What is the link to the Apache JIRA HDDS-16145 ## How was this patch tested? Added testcases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
