ss77892 commented on code in PR #11080:
URL: https://github.com/apache/ozone/pull/11080#discussion_r4169748494
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerGrpc.java:
##########
@@ -234,6 +236,7 @@ public void stop() {
try {
server.shutdown();
server.awaitTermination(5, TimeUnit.SECONDS);
+ xceiverService.shutdown();
Review Comment:
This movement wouldn't change anything. The timer thread only starts when
the first idle check is scheduled, which happens only after the datanode has
served a streaming read. If stop() runs while isStarted == false, the server
never served anything, so there is no thread to leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
