smengcl commented on code in PR #11419:
URL: https://github.com/apache/ozone/pull/11419#discussion_r4223669990
##########
hadoop-ozone/dist/src/main/compose/xcompat/test-old.sh:
##########
@@ -25,6 +25,11 @@ export COMPOSE_DIR
# shellcheck source=hadoop-ozone/dist/src/main/compose/xcompat/lib.sh
source "${COMPOSE_DIR}/lib.sh"
+# test specific version(s)
+if [[ -n "${OZONE_OLD_VERSIONS}" ]]; then
Review Comment:
Should we default this optional variable to empty? With `set -u`, an unset
`OZONE_OLD_VERSIONS` aborts the script with `unbound variable` before starting
any cluster. This breaks direct execution, compose `test-all.sh`, and
`acceptance.sh` without a suite. The linked fork CI passes because every split
supplies the variable.
This preserves the default behavior of testing all old versions:
```suggestion
if [[ -n "${OZONE_OLD_VERSIONS:-}" ]]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
