sarvekshayr commented on code in PR #11419:
URL: https://github.com/apache/ozone/pull/11419#discussion_r4226825677
##########
.github/workflows/ci.yml:
##########
@@ -324,6 +325,35 @@ jobs:
strategy:
matrix:
suite: ${{ fromJson(needs.build-info.outputs.acceptance-suites) }}
+ exclude:
+ - suite: compat-old
+ fail-fast: false
+
+ # acceptance (compat-old), split by old Ozone version
+ compat-old:
+ name: acceptance (compat-old)
+ needs:
+ - build-info
+ - build
+ - basic
+ - dependency
+ - license
+ if: needs.build-info.outputs.needs-compose-tests == 'true'
+ uses: $/.github/workflows/check.yml
+ secrets:
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+ with:
+ needs-ozone-binary-tarball: true
+ ratis-args: ${{ inputs.ratis_args }}
+ script: acceptance
+ script-args: compat-old ${{ matrix.version }}
+ sha: ${{ needs.build-info.outputs.sha }}
+ split: ${{ matrix.version }}-compat
Review Comment:
The CI sidebar shows `acceptance (<matrix.version>-compat)` for the
old-cluster runs. It doesn't say it's the old-cluster suite and reads
differently from `acceptance (compat-new)`. This change puts the suite name
first and the sidebar would show `acceptance (compat-old-<matrix.version>)`
```suggestion
split: compat-old-${{ matrix.version }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
