cchung100m commented on code in PR #11435:
URL: https://github.com/apache/ozone/pull/11435#discussion_r4226444262
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyInputStream.java:
##########
@@ -104,10 +105,17 @@ private static List<BlockExtendedInputStream>
createStreams(
return partStreams;
}
- private static BlockLocationInfo getBlockLocationInfo(OmKeyInfo newKeyInfo,
+ @VisibleForTesting
Review Comment:
Thanks, I’ll remove the @VisibleForTesting annotation. I’m keeping the
method package-private so the unit test in the same package can call it
directly. If you’d prefer that I leave the method private and test it through
getFromOmKeyInfo with a method BlockInputStreamFactory, I can switch to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
