Copilot commented on code in PR #11488: URL: https://github.com/apache/ozone/pull/11488#discussion_r4246018272
########## AGENTS.md: ########## @@ -165,11 +165,18 @@ Key paths: Do not rewrite branch history unless explicitly asked. - To bring a branch up to date with `master`, merge instead of rebasing: `git merge --no-edit origin/master` - Avoid force-push when updating a PR unless a maintainer explicitly asks for rewritten history. +- Committers: keep about one hour between merges to `master` so the GitHub Actions queue has room for other PRs. Review Comment: “keep about one hour” is ambiguous and hard to follow consistently. Consider making this guidance measurable (e.g., “keep at least 1 hour…”) or framing it as conditional (e.g., only when the queue is backed up) so expectations are clearer. ########## AGENTS.md: ########## @@ -165,11 +165,18 @@ Key paths: Do not rewrite branch history unless explicitly asked. - To bring a branch up to date with `master`, merge instead of rebasing: `git merge --no-edit origin/master` - Avoid force-push when updating a PR unless a maintainer explicitly asks for rewritten history. +- Committers: keep about one hour between merges to `master` so the GitHub Actions queue has room for other PRs. +- Committers: allow at least 24 hours for contributors in all time zones to provide feedback before merging non-trivial PRs, except for CI-breakage fixes. +- Before opening or marking a PR ready, run a clean fork CI check. Keep the PR in draft while the implementation is unstable, review comments are open, or fork CI is failing; do not spend CI resources on obsolete revisions. +- Trigger CI only when the change is necessary, and do not rerun unrelated flaky tests that are already fixed on `master`. +- Keep distinct issues separate. Avoid unrelated changes, and move build changes, refactoring, or cleanup into a follow-up PR when they obscure the functional change. For cleanup, consider compatibility and deprecation before removing public interfaces, and notify the original authors when practical. Review Comment: These bullets are dense and mix multiple directives, which makes the guidance harder to scan. Consider splitting line 172 into 2–3 shorter bullets (separating “avoid unrelated changes”, “move refactors/cleanup to follow-up PRs”, and “compatibility/deprecation expectations”) to improve readability and reduce misinterpretation. ########## AGENTS.md: ########## @@ -165,11 +165,18 @@ Key paths: Do not rewrite branch history unless explicitly asked. - To bring a branch up to date with `master`, merge instead of rebasing: `git merge --no-edit origin/master` - Avoid force-push when updating a PR unless a maintainer explicitly asks for rewritten history. +- Committers: keep about one hour between merges to `master` so the GitHub Actions queue has room for other PRs. +- Committers: allow at least 24 hours for contributors in all time zones to provide feedback before merging non-trivial PRs, except for CI-breakage fixes. +- Before opening or marking a PR ready, run a clean fork CI check. Keep the PR in draft while the implementation is unstable, review comments are open, or fork CI is failing; do not spend CI resources on obsolete revisions. Review Comment: The term “clean fork CI check” is unclear to new contributors (what workflow, what inputs, and what constitutes “clean”). Consider adding a brief definition (e.g., which CI job(s) to run and expected state) or a link/anchor to the project’s standard fork CI procedure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
