andyhuangdev opened a new pull request, #11522:
URL: https://github.com/apache/ozone/pull/11522

   ## What changes were proposed in this pull request?
   
   This patch changes StorageContainerManager.shutDown() to terminate with exit 
status 1 instead of 0 after a fatal error. This allows supervisors configured 
to restart on failure to recognize the failure and makes Ratis log the 
termination at ERROR.
   
   HDDS-6930 introduced status 0 to accommodate normal shutdown. Since 
HDDS-10643, SCMStateMachine.close() skips termination when SCM is already 
stopping, so that normal shutdown path no longer requires status 0.
   
   A regression test verifies that normal SCM shutdown does not trigger process 
termination, while state machine closure by Ratis terminates SCM with status 1.
   
   ## What is the link to the Apache JIRA
   
   [HDDS-16922](https://issues.apache.org/jira/browse/HDDS-16922)
   
   ## How was this patch tested?
   
   The regression test failed before the fix with expected: 1 but was: 0 and 
passed after the fix.
   
   The following checks passed:
   
   - TestStorageContainerManager: 10 tests.
   - TestSCMStateMachine, TestSCMHAManagerImpl, TestRootCARotationManager, and 
TestBackgroundPipelineCreator: 26 tests.
   - ./hadoop-ozone/dev-support/checks/checkstyle.sh
   - git diff --check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to