chihsuan commented on code in PR #11574:
URL: https://github.com/apache/ozone/pull/11574#discussion_r4302369418
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -1262,6 +1262,9 @@ boolean setSafeMode(SafeModeAction action, boolean
isChecked)
@Override
Map<String, String> getObjectTagging(OmKeyArgs args) throws IOException;
+ Map<String, String> getObjectTagging(OmKeyArgs args,
+ boolean assumeS3Context) throws IOException;
Review Comment:
nit: Same here, could we add javadoc for `assumeS3Context`?
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java:
##########
@@ -1680,6 +1680,10 @@ default void setVerifyChecksum(boolean verifyChecksum) {
Map<String, String> getObjectTagging(String volumeName, String bucketName,
String keyName)
throws IOException;
+ Map<String, String> getObjectTagging(String volumeName,
+ String bucketName, String keyName, boolean assumeS3Context)
+ throws IOException;
Review Comment:
nit: Could we add javadoc here? `volumeName` is not used when
`assumeS3Context` is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
