Russole commented on PR #11574: URL: https://github.com/apache/ozone/pull/11574#issuecomment-6247216049
> Thanks for the patch! @Russole This looks solid overall. > > Just a question about where the flag lives. #11479 and #11449 put it on `OMRequest`, but this PR puts it on the tagging request. A shared flag is one place, but unsupported calls ignore it silently. A per-request flag is clearer, but each call needs its own field. What do you think? Good point, I agree. Moving `assumeS3Context` to `OMRequest` keeps the request structure consistent with #11479 and #11449, and makes this shared S3 context behavior easier to discover and maintain. I’ve updated the patch accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
