Gargi-jais11 commented on code in PR #11870:
URL: https://github.com/apache/ozone/pull/11870#discussion_r4439542615
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -505,6 +507,13 @@ Response handleGetRequest(ObjectRequestContext context,
String keyPath)
}
}
+ private static void validatePartNumberAndRange(int partNumber, String
rangeHeaderVal, String keyPath) {
+ if (partNumber != 0 && rangeHeaderVal != null) {
Review Comment:
The parameterized tests treat `""` as conflicting with partNumber. Real
clients rarely send an empty Range; if the stack ever returns whitespace-only
values, behavior may differ from AWS.
May be we can use -> `StringUtils.isNotBlank(rangeHeaderVal)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
