adwetojha commented on PR #11752: URL: https://github.com/apache/ozone/pull/11752#issuecomment-6687249672
> Thanks for addressing the feedback! @adwetojha I noticed this now conflicts with master. > > Since [HDDS-17562](https://issues.apache.org/jira/browse/HDDS-17562) raised the client version to 4, the `CURRENT == 3` check may start failing. Could we remove it when rebasing? I also found that the old-client check in the `CreateKey` test passes with any version, so it might not be needed. > Thanks for addressing the feedback! @adwetojha I noticed this now conflicts with master. > > Since [HDDS-17562](https://issues.apache.org/jira/browse/HDDS-17562) raised the client version to 4, the `CURRENT == 3` check may start failing. Could we remove it when rebasing? I also found that the old-client check in the `CreateKey` test passes with any version, so it might not be needed. Thanks for catching this! I've rebased the PR onto upstream master, preserving the client version 4 introduced by HDDS-17562. I've also removed the hardcoded `CURRENT == 3` assertion from `TestRequestValidations` and the redundant older-client check from the `CreateKey` test. All 521 targeted tests passed locally after the rebase, along with checkstyle and protobuf compatibility checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
