[
https://issues.apache.org/jira/browse/HDDS-17757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gargi Jaiswal updated HDDS-17757:
---------------------------------
Description:
{{Enable SCR read for EC keys as well.}}
{{XceiverClientManager.getPipelineCacheKey}} skips short-circuit read when
{{{}pipeline.getType() == EC{}}}. That check never applies to EC key reads.
{{ECBlockInputStream}} reads each index through a one-node {{STAND_ALONE}}
pipeline with the replica index set, so {{isEC}} is false, and local EC reads
already use short-circuit read. An EC-typed pipeline always gets
{{ECXceiverClientGrpc}} in {{{}XceiverClientCreator{}}}, whatever the cache key
says.
Remove the {{!isEC}} condition from the short-circuit branch and keep the EC
host:port cache-key logic. EC read behavior does not change.
Refer to understand the origin of this issue:
[https://issues.apache.org/jira/browse/HDDS-17606]
was:
{{Enable SCR read for EC keys as well.}}
{{*getPipelineCacheKey*}} ** has a {color:#00875a}{{!isEC}} {color}condition on
the short-circuit branch, which looks as if EC keys are excluded from SCR.
In practice that check is not what limits EC short-circuit reads. EC reads go
through the EC client path, and SCR behavior is determined elsewhere.
Remove the redundant {{!isEC}} guard on the SCR path for clarity.
Refer to understand the origin of this issue:
[https://issues.apache.org/jira/browse/HDDS-17606]
> Remove redundant EC guard on SCR path in XceiverClientManager
> -------------------------------------------------------------
>
> Key: HDDS-17757
> URL: https://issues.apache.org/jira/browse/HDDS-17757
> Project: Apache Ozone
> Issue Type: Task
> Reporter: Gargi Jaiswal
> Assignee: Gargi Jaiswal
> Priority: Minor
>
> {{Enable SCR read for EC keys as well.}}
> {{XceiverClientManager.getPipelineCacheKey}} skips short-circuit read when
> {{{}pipeline.getType() == EC{}}}. That check never applies to EC key reads.
> {{ECBlockInputStream}} reads each index through a one-node {{STAND_ALONE}}
> pipeline with the replica index set, so {{isEC}} is false, and local EC reads
> already use short-circuit read. An EC-typed pipeline always gets
> {{ECXceiverClientGrpc}} in {{{}XceiverClientCreator{}}}, whatever the cache
> key says.
> Remove the {{!isEC}} condition from the short-circuit branch and keep the EC
> host:port cache-key logic. EC read behavior does not change.
> Refer to understand the origin of this issue:
> [https://issues.apache.org/jira/browse/HDDS-17606]
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]