ss77892 commented on code in PR #11874:
URL: https://github.com/apache/ozone/pull/11874#discussion_r4514467765


##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -334,7 +347,8 @@ public ContainerCommandResponseProto sendCommand(
     for (DatanodeDetails dn : datanodeList) {
       try {
         request = reconstructRequestIfNeeded(request, dn);
-        futureHashMap.put(dn, sendCommandAsync(request, dn).getResponse());
+        // the caller waits for the replies one by one, so the requests to the 
other nodes must not wait for it
+        futureHashMap.put(dn, sendCommandAsync(request, dn, new 
CompletableFuture<>()).getResponse());

Review Comment:
   Removed that line from the Jira rather than adding the cancellation. Fan-out 
requests use plain futures and keep their gRPC deadline, so they finish on 
their own and return their permits, which 
`fanOutThatCannotReachANode...ReleasesThePermits` checks.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to