ss77892 commented on code in PR #11874: URL: https://github.com/apache/ozone/pull/11874#discussion_r4514577536
########## hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/TestXceiverClientGrpcCallerRuns.java: ########## @@ -0,0 +1,585 @@ +/* Review Comment: - **Two responses to one request:** added. - **`join()`:** not added, since it isn't supported on this future and is now documented that way. - **Non-Ozone span:** `tracedCommandsUseStreamPerCall` already covers it, because it wraps a plain `SpanContext` that didn't come from Ozone's tracer. - **Write command and error response:** not added. `PooledStream.onNext` doesn't look at the command type or the result, so these take the same path as the reply tests. Dropping the stream after `onError` is covered by `streamErrorFailsOnlyItsRequestAndDropsTheStream`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
