devmadhuu commented on code in PR #11926:
URL: https://github.com/apache/ozone/pull/11926#discussion_r4512085697


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java:
##########
@@ -121,6 +125,11 @@ public void importContainer(long containerID, Path 
tarFilePath,
       }
       ContainerUtils.verifyContainerFileChecksum(containerData, conf);
       containerData.setVolume(targetVolume);
+      // Preserve the replica's recorded type, which can differ from a 
relabelled volume's type.
+      // Initialise missing legacy metadata from the destination volume; 
reports also expose the volume type separately.
+      if (containerData.getStorageType() == null) {

Review Comment:
   @amaliujia Also just to clarify that though in this PR, we'll preserve 
legacy null metadata during import. Assigning a storage type as part of an 
RM-directed repair is separate work: sp RM will do the selected repair type on 
the newly created replica, without backfilling existing source replicas, while 
reconciling it with the agreed handling of known replica types and relabelled 
volumes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to