amaliujia commented on code in PR #11926:
URL: https://github.com/apache/ozone/pull/11926#discussion_r4533246649


##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -577,6 +577,9 @@ message SendContainerRequest {
   optional int64 checksum = 4;
   optional CopyContainerCompressProto compression = 5;
   optional int64 size = 6;
+  // StorageType the importing datanode should place the container on. Sent on
+  // the first request only, alongside size. Absent from older senders.
+  optional int32 storageTypeID = 7;

Review Comment:
   Thanks for the clarification. Can you leave a comment for the context why 
not re-use and also a TODO says we can re-use the same proto? 
   
   I would imagine future folks could have the same question. A TODO probably 
won't never happen, but that would be the way to answer people's question and 
justify current decision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to