symious opened a new pull request, #12016:
URL: https://github.com/apache/ozone/pull/12016
## What changes were proposed in this pull request?
Once transactionToDNsCommitMap reached its limit, SCMBlockDeletingService
skipped the whole round. That also stopped the timeout cleanup and the
resending of transactions whose commands were lost, so their entries waited for
ACKs that never came and block deletion stayed stuck until an SCM leader change.
- Over the limit, only new transactions are held back. The round still
runs: timed out commands are cleaned up and transactions already in the map are
resent (only to the datanodes that have not committed them). Resending does not
add entries, so the map cannot grow while it drains.
DeletedBlockLog#getTransactions gets a retryOnly flag for this; the existing
two-argument method delegates with false.
- Map entries that no datanode has committed are dropped when their
commands time out or their datanode is marked dead. Such an entry carries no
information and is recreated when the transaction is resent. Entries with
partial commits are kept, so resends only go to the missing datanodes.
- DeletedBlockLogImpl#onDatanodeDead now takes the log lock, like ACK
processing, since it now touches the map.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17787
## How was this patch tested?
New unit tests:
- TestDeletedBlockLog#testRetryOnlyResendsOnlyTransactionsInCommitMap
- TestDeletedBlockLog#testTimedOutUncommittedTransactionsLeaveCommitMap
- TestDeletedBlockLog#testDeadDatanodeDropsUncommittedTransactions
- TestSCMBlockDeletingService#testFullCommitMapOnlyRetries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]