cchung100m commented on PR #11505:
URL: https://github.com/apache/ozone/pull/11505#issuecomment-6796168949

   Hi @chungen0126 
   Thanks for the workflow and for confirming that SCM has a single Raft group. 
I implemented it as suggested:
   1. `scmInit` now fails before the VERSION file is written if the Ratis 
storage directory contains any Raft group directory, so a rerun can no longer 
take the "already initialized" branch with a stale directory.
   2. `SCMRatisServerImpl` fails in both the constructor and `initialize()`, 
before `build()`, if the directory contains a group other than this cluster's. 
The `IOException` names the directory and tells the user to remove it if it was 
left by a previous cluster.
   
   I kept the `applyTransaction` skip on the bootstrap state machine as a 
safety net, as proposed in the earlier comment. The test is replaced by 
`testInitializeFailsWithStaleRaftGroup`, and the skip is still covered by 
`TestSCMStateMachine`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to