cchung100m commented on PR #11505: URL: https://github.com/apache/ozone/pull/11505#issuecomment-7058506178
Hi @sumitagrawl Thank you for the review. Below are the changes I propose and the questions I have not verified. ### Proposed changes: - Replace the "skip" and return `Message.EMPTY` in `applyTransaction` with `ExitUtils.terminate`, and update `testBootstrapStateMachineSkipsApplyTransaction` accordingly. - Remove the `null` sentinel by giving `verifyNoRaftGroup` and `verifyNoOtherRaftGroup` separate, explicit conditions and messages. - Add a test that the `SCMRatisServerImpl` constructor fails when a stale group directory exists. ### Questions - Do you prefer terminating in `applyTransaction`, or removing the `!isInitialized` branch and relying on the pre-start check only? - In `scmInit`, a failed check is logged as "Could not initialize SCM version file". Is that acceptable, or should the check move outside the `try`? - The pre-start check allows the SCM's own group. Should `--init` reject a rerun whose own group already contains data entries? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
