ChenSammi commented on PR #11975: URL: https://github.com/apache/ozone/pull/11975#issuecomment-6798297173
> Thanks @ChenSammi for the review. I would like to ask: if there is already an approving review, and you would like some changes, please don't feel bad about choosing "request changes". In its current state the PR list shows "approved" for this one. Yet we are still waiting for changes requested in 👁️ review. @adoroszlai, yeah, I'm not very used to use "request changes" unless I think it's fundamental problem that need be fixed. "request changes" sound a very serious feedback to me. I guess it's approved but not merged is because the approver wants to have more eyes review on it, and our community contributors are often very open to reasonable comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
