adoroszlai commented on PR #11975:
URL: https://github.com/apache/ozone/pull/11975#issuecomment-6798994203

   > "request changes" sound a very serious feedback to me.
   
   Yes, that's exactly what I meant by "don't feel bad about" it.  And I only 
ask that reviewers "request changes" if there is already another approval.
   
   The reason I ask is that some committers (including me) regularly look for 
PRs that can be merged (reviewer approved, CI passed, no conflicts, etc.).  The 
goal is to avoid PRs getting forgotten for days or even longer, since then they 
have an increased chance of conflicts, or worse: breaking without conflicts, 
due to other commits on `master`.
   
   These "approved but not completely" PRs, like this one, appear in the list 
as "approved", so you need to open it only to see that it's still pending.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to