rajeshkumarchandolu opened a new pull request, #12033: URL: https://github.com/apache/ozone/pull/12033
## What changes were proposed in this pull request? * Add the `IOMClientRequest` interface with the operations that callers outside the request class use: `preExecute`, `handleRequestFailure`, `validateAndUpdateCache`, `getAuditBuilder`, `getOmRequest` and `getUserInfo`. It extends `RequestAuditor`. `OMClientRequest` now implements it. * `OzoneManagerRatisUtils#createClientRequest` returns `IOMClientRequest`. The callers (`OzoneManagerRequestHandler`, `OMExecutionFlow`, `KeyLifecycleService`, `TrashOzoneFileSystem`, `OMAuditLogger`) use the interface instead of `OMClientRequest`. * In `pmd-ruleset.xml`, skip the `MissingOverride` check for `OMClientRequest#preExecute`. Checkstyle requires an `@Override preExecute` to call `super`, and `OMClientRequest#preExecute` is the root implementation, so it has no super to call. These changes are needed for the tracing proxies in OM (HDDS-17586). The client request will be wrapped in a tracing proxy so that every request gets its own span. A tracing proxy is a JDK dynamic proxy and implements only the interface, so callers can't keep using the `OMClientRequest` class. This PR doesn't add any tracing itself, and there is no functional change. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-17598 ## How was this patch tested? * `mvn -pl :ozone-manager -am test-compile -DskipShade -DskipRecon`: BUILD SUCCESS * `checkstyle:check` on `ozone-manager`: clean * Existing OM request tests, which run through the changed code paths * CI `build-branch` on fork branch `om-iomclientrequest-interface`: <run URL> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
