sodonnel commented on PR #12024:
URL: https://github.com/apache/ozone/pull/12024#issuecomment-6830677785

   Poking around this change with Claude, it thinks that if pipelines fail to 
close, even a Ratis One pipeline, then safemode will get suck forever.
   
   I guess we need to consider:
   
   1) Is it possible for pipelines to fail to close forever (I think they get 
force closed at some point)?
   
   2) If some pipelines do fail to close, then blocking safemode exit is the 
correct thing in this design, I think.
   
   Aside from that I couldn't find any other issues of note. There were a few 
other issues it highlighted that I don't think are relevant or worth fixing.
   
   I will wait to see if you have any further refinements today and then give 
the change another pass, and check the tests which I have not looked at yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to