lpavanvenkat commented on PR #11685: URL: https://github.com/apache/ozone/pull/11685#issuecomment-6844872010
@errose28 @sumitagrawl @devmadhuu @priyeshkaratha @smengcl, I've reworked the PR to the approach agreed above and updated the description. Please take another look. Summary of the change: - Multipart open keys (`isMultipartKey=true`, size 0) are excluded from `/keys/open` and `/keys/open/summary`. Incomplete MPUs are reported only by `/keys/open/mpu/summary`. - Open keys of parts still being written are not multipart open keys, so they are still listed and counted as open keys until they commit. - A Recon upgrade action (version 7) queues a task reinitialization so the open key totals stored by older versions are recomputed. - The restart fix in `MultipartInfoInsightHandler` (caching the replication config on the `multipartInfoTable` DELETE event) is kept. - The earlier approach (adding committed part sizes to the open key endpoints) has been removed. On the earlier review comments: - @devmadhuu: the lookup of older FSO multipart open keys by key name no longer applies, since the PR no longer resolves the upload from the key path. Keys are filtered by the `isMultipartKey` flag only. The remaining limitation, for keys created before HDDS-9017 without the flag, is noted in the description. - @priyeshkaratha: `/keys/open` and `/keys/open/summary` now exclude the same keys with the same check, so their totals no longer diverge because of MPUs. - The Copilot comments refer to `getOpenKeySummaryWithMPU` and `getCommittedPartsSize`, which have been removed. I tested an upgrade from master on a compose cluster. The details are in the "How was this patch tested?" section. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
