amaliujia commented on code in PR #12075:
URL: https://github.com/apache/ozone/pull/12075#discussion_r4614961931
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -251,12 +253,16 @@ long getStartTime() {
@SuppressWarnings("parameternumber")
public ContainerStateMachine(HddsDatanodeService hddsDatanodeService,
RaftGroupId gid,
+ ReplicationType replicationType,
Review Comment:
I believe when I read section 4.2 from the design doc:
https://github.com/apache/ozone/pull/11982/changes#diff-9f932235b1dd6d8e60276cef9b9b28dffeb74ad942931a34d414e301a41c1f12R220,
it pretty much says we keep the container state machine unaware of the type.
The type is stored in XceiverServerRatis and looked up on demand.
However the implementation here turned into the idea of having a replication
type within the SM. Does then we turn the design to a chained pipeline binds
with a dedicated Ratis group and ContainerStateMachine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]