szetszwo commented on code in PR #12075:
URL: https://github.com/apache/ozone/pull/12075#discussion_r4615105128


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -251,12 +253,16 @@ long getStartTime() {
 
   @SuppressWarnings("parameternumber")
   public ContainerStateMachine(HddsDatanodeService hddsDatanodeService, 
RaftGroupId gid,
+      ReplicationType replicationType,

Review Comment:
   @amaliujia , adding ReplicationType to ContainerStateMachine is to avoid 
non-zero bcsid.  If a ContainerStateMachine support both V1 and V3 containers, 
V1 containers will change the bcsid and cause confusing.  In HDDS-17543, we 
will disable Raft in V3 ContainerStateMachine and disable StreamCommand in V1 
ContainerStateMachine, in order to avoid mixing them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to