ChenSammi commented on code in PR #12102:
URL: https://github.com/apache/ozone/pull/12102#discussion_r4639101827


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3sts/S3STSEndpoint.java:
##########
@@ -225,7 +234,7 @@ private Response handleAssumeRole(Set<String> 
paramNamesToValidate, String roleA
     int duration = S3STSUtils.DEFAULT_DURATION_SECONDS;
     String durationValidationError = null;
     try {
-      duration = S3STSUtils.validateDuration(durationSeconds);
+      duration = S3STSUtils.validateDuration(durationSeconds, 
S3STSUtils.getMinDurationSeconds(ozoneConfiguration));

Review Comment:
   Can we save this S3STSUtils.getMinDurationSeconds(ozoneConfiguration) to a 
global value? 
   
   Other part looks good to me. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to