fmorg-git commented on code in PR #12102:
URL: https://github.com/apache/ozone/pull/12102#discussion_r4648005227


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3sts/S3STSEndpoint.java:
##########
@@ -225,7 +234,7 @@ private Response handleAssumeRole(Set<String> 
paramNamesToValidate, String roleA
     int duration = S3STSUtils.DEFAULT_DURATION_SECONDS;
     String durationValidationError = null;
     try {
-      duration = S3STSUtils.validateDuration(durationSeconds);
+      duration = S3STSUtils.validateDuration(durationSeconds, 
S3STSUtils.getMinDurationSeconds(ozoneConfiguration));

Review Comment:
   updated



##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -740,6 +740,12 @@ public final class OzoneConfigKeys {
       "ozone.s3g.sts.http.enabled";
   public static final boolean OZONE_S3G_STS_HTTP_ENABLED_DEFAULT = false;
 
+  /**
+   * Test-only: override the minimum AssumeRole {@code DurationSeconds} 
accepted by OM and S3 Gateway STS.
+   * Values may only lower the AWS-compatible minimum of 900 seconds.  Valid 
range is 1-900.
+   */
+  public static final String OZONE_S3G_STS_TEST_MIN_DURATION_SECONDS_KEY = 
"ozone.s3g.sts.test.min.duration.seconds";
+

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to