errose28 commented on a change in pull request #2892:
URL: https://github.com/apache/ozone/pull/2892#discussion_r768960152
##########
File path: hadoop-hdds/interface-admin/src/main/resources/proto.lock
##########
@@ -1334,7 +1334,7 @@
},
{
"id": 3,
- "name": "idleiterations",
Review comment:
Don't EVER change proto lock files! These are automatically updated by
protolock only on each major or minor release to ensure compatibility. This is
an easy mistake to make when proto-backwards-compatability-check fails though,
and it would definitely be helpful if our CI could help the devs out here : )
@adoroszlai is there an easy check we can put in CI to fail PRs that that
modify anything called proto.lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
