siddhantsangwan commented on a change in pull request #2892:
URL: https://github.com/apache/ozone/pull/2892#discussion_r769470436
##########
File path: hadoop-hdds/interface-admin/src/main/resources/proto.lock
##########
@@ -1334,7 +1334,7 @@
},
{
"id": 3,
- "name": "idleiterations",
Review comment:
Good catch. This seems to have sneaked in while I was refactoring this
field's name across the project. CI got skipped since this is still a draft PR.
BTW, from what I understand, it's compatible to change the name of a proto
field as long as the ID and type remain the same, and JSON is not involved. The
[hadoop
policy](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/Compatibility.html#Policy)
that's linked
[here](https://github.com/apache/ozone/blob/af4730a54bd2bbc63d556936292ae760701b7e7f/hadoop-hdds/interface-admin/src/main/proto/ScmAdminProtocol.proto#L21)
also says it's compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
