umamaheswararao commented on a change in pull request #2910:
URL: https://github.com/apache/ozone/pull/2910#discussion_r770189001



##########
File path: 
hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/MultiNodePipelineBlockAllocator.java
##########
@@ -85,4 +110,34 @@ public MultiNodePipelineBlockAllocator(OzoneConfiguration 
conf,
         .setLength(blockSize).build());
     return results;
   }
+
+  private void addMembers(HddsProtos.Pipeline.Builder builder,
+      int nodesNeeded, Set<DatanodeDetails> datanodes,

Review comment:
       Yeah, it should be excludedDataNodes for better readbility. I have just 
updated, thanks for pointing.

##########
File path: 
hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/MultiNodePipelineBlockAllocator.java
##########
@@ -85,4 +110,34 @@ public MultiNodePipelineBlockAllocator(OzoneConfiguration 
conf,
         .setLength(blockSize).build());
     return results;
   }
+
+  private void addMembers(HddsProtos.Pipeline.Builder builder,
+      int nodesNeeded, Set<DatanodeDetails> datanodes,

Review comment:
       Yeah, it should be excludedDataNodes for better readability. I have just 
updated, thanks for pointing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to