fapifta commented on a change in pull request #2910:
URL: https://github.com/apache/ozone/pull/2910#discussion_r770062801
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -303,13 +327,40 @@ private StripeWriteStatus handleParityWrites(int
parityCellSize,
if (allocateBlockIfFull) {
blockOutputStreamEntryPool.allocateBlockIfNeeded();
}
+ currentBlockGroupLen = 0;
} else {
streamEntry.resetToFirstEntry();
}
- currentBlockGroupLen = 0;
+
return StripeWriteStatus.SUCCESS;
}
+ private boolean isDataWriteSuccess() {
Review comment:
For now I can accept the current state, but on the long run, I think all
this should be in the BlockOutputStreamEntry not even in the pool level, as the
entry handles a blockgroup and I believe it should also handle the write encode
and retry logic, as that would massively simplify some parts of the code, but
that we already discussed and agreed to deal with later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
