lokeshj1703 commented on a change in pull request #3239:
URL: https://github.com/apache/ozone/pull/3239#discussion_r836096199
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerMetrics.java
##########
@@ -57,6 +57,14 @@
@Metric(about = "Number of unbalanced datanodes.")
private MutableCounterLong numDatanodesUnbalanced;
+ @Metric(about = "Total number of container moves across all iterations of " +
+ "Container Balancer.")
+ private MutableCounterLong totalNumContainerMoves;
+
+ @Metric(about = "Total data size in GB moved across all iterations of " +
+ "Container Balancer.")
+ private MutableCounterLong totalSizeMovedGB;
Review comment:
Rename to dataSizeMovedGB
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerMetrics.java
##########
@@ -57,6 +57,14 @@
@Metric(about = "Number of unbalanced datanodes.")
private MutableCounterLong numDatanodesUnbalanced;
+ @Metric(about = "Total number of container moves across all iterations of " +
+ "Container Balancer.")
+ private MutableCounterLong totalNumContainerMoves;
Review comment:
Rename to numContainerMoves since we already have inLatestIteration
suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
