guihecheng commented on code in PR #3345: URL: https://github.com/apache/ozone/pull/3345#discussion_r858469466
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReconstructECContainersCommand.java: ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.protocol.commands; + +import java.util.List; +import java.util.stream.Collectors; + +import com.google.protobuf.ByteString; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.ReconstructECContainersCommandProto; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.ReconstructECContainersCommandProto + .Builder; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.SCMCommandProto.Type; + +import com.google.common.base.Preconditions; + +/** + * SCM command to request reconstruction of EC containers. + */ +public class ReconstructECContainersCommand + extends SCMCommand<ReconstructECContainersCommandProto> { + + private final long containerID; + private final List<DatanodeDetails> sourceDatanodes; + private final List<DatanodeDetails> targetDatanodes; + private final byte[] missingContainerIndexes; Review Comment: Hi Uma, the info looks good, I wonder whether there are additional info needed, for example: - ReplicaIndexes for sourceDatanodes, maybe we could learn this from the HealthyDNs in the group, but the `readContainer` grpc call don't provides this index for now, so if SCM carries this, it then we don't have to worry about it. - The pipelineID may be needed to reconstruct the container, see `ContainerData#originPipelineId`. SCM manages the pipelineID, so it is reasonable for it to deliver this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
